Messages in this thread | | | Date | Wed, 22 Oct 2003 15:51:37 +0100 | From | Christoph Hellwig <> | Subject | Re: [PATCH] Altix console driver |
| |
On Wed, Oct 22, 2003 at 09:39:12AM -0500, Pat Gefre wrote: > + > Were all the points which Christoph raised considered? > + > + No. > + > > Which item(s), specifically, do you have an issue with ?
You're still registering with the normal serial major/minor without using serial core. That means the normal serial driver can't be used when sn_serial is loaded, e.g. for using a pci serial card in an altix. The irq mess still isn't fixed - this isn't exactly an issue with this driver but I exposing the bloody mess outside arch/ia64/sn is a very bad idea. I'd suggest kicking ajm to fix that up.
pciio.h has no business beeing included in this driver that doesn't use anything PCIish, again a core SN issue that needs fixing.
Also after reading through the new comment ontop of the file it might be a good idea to rename it to sn_console.c, especially now that there is a real ioc4 serial driver.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |