lkml.org 
[lkml]   [2003]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] 2.4.23-pre7 vmscan.c typo


On Mon, 20 Oct 2003, Andrea Arcangeli wrote:

> On Sun, Oct 19, 2003 at 10:00:05PM -0700, Andrew Morton wrote:
> > Shantanu Goel <sgoel01@yahoo.com> wrote:
> > >
> > > The following appears to be a typo in mm/vmscan.c
> > >
> >
> > It sure is. Scary.
>
> indeed, great spotting.
>
> >
> > --- a/mm/vmscan.c 2003-10-19 21:36:26.000000000 -0400
> > +++ a/mm/vmscan.c 2003-10-19 21:37:17.000000000 -0400
> > @@ -596,7 +596,7 @@
> > continue;
> > }
> >
> > - nr_pages--;
> > + ratio--;
> >
> > del_page_from_active_list(page);
> > add_page_to_inactive_list(page);
> >
> >
> >
> > I note that `ratio' here is the number of pages which we try to deactivate
> > rather than the number of pages which we scan. Is this intentional?
>
> yes, it's intentional, this ensures we refile a number of pages and that
> we don't only roll the list, it won't loop forever since at the second
> pass the referenced bit will be clear.
>
> BTW, the above obviously correct patch was apparently due an half merge
> error too, this is what my 2.4.22aa1 or alternatively 2.4.23pre6aa3
> looks like in this area.

Fixed. Thanks Shantanu.

It must have been a merge error. :(

> This gets right the highmem case too, so that we ensure to refile normal
> zone if the user is GFP_KERNEL and we don't deactivate highmem unless
> it's worthwhile, and it has the bh-related knwoledge, so over time it'd
> be better to merge these bits too.

Will take a look into this...


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:58    [W:0.111 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site