Messages in this thread Patch in this message | | | Date | Sun, 19 Oct 2003 21:36:15 -0700 (PDT) | From | "Noah J. Misch" <> | Subject | [PATCH] Remove needless and non-portable include in mtd |
| |
Hello David,
The #include <asm/setup.h> in drivers/mtd/cmdlinepart.c does not appear to provide any definition this file uses, and it quickly breaks builds on architectures that lack such a header, including ia64 and sparc.
This applies to your CVS and linux-2.5 BK as of 0700 UTC 10/20/2003 and passes an allyesconfig on (with unrelated exceptions) i386, ia64, and sparc. I do not have the hardware to test it further, but I think the change is straightforward. Please let me know if you need further information.
I will probably send you at least one more MTD compatibility patch.
Thanks, Noah
# This is a BitKeeper generated patch for the following project: # Project Name: Linux kernel tree # This patch format is intended for GNU patch command version 2.5 or higher. # This patch includes the following deltas: # ChangeSet 1.1369 -> 1.1370 # drivers/mtd/cmdlinepart.c 1.5 -> 1.6 # # The following is the BitKeeper ChangeSet Log # -------------------------------------------- # 03/10/16 noah@caltech.edu 1.1370 # Remove needless include of asm/setup.h in drivers/mtd/cmdlinepart.c. This # was breaking compilation on architectures that lack such a header. # -------------------------------------------- # diff -Nru a/drivers/mtd/cmdlinepart.c b/drivers/mtd/cmdlinepart.c --- a/drivers/mtd/cmdlinepart.c Fri Oct 17 13:40:56 2003 +++ b/drivers/mtd/cmdlinepart.c Fri Oct 17 13:40:56 2003 @@ -28,7 +28,6 @@
#include <linux/mtd/mtd.h> #include <linux/mtd/partitions.h> -#include <asm/setup.h> #include <linux/bootmem.h>
/* error message prefix */ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |