Messages in this thread Patch in this message | | | Date | Wed, 15 Oct 2003 10:38:29 +1000 | From | Eyal Lebedinsky <> | Subject | 2.6.0-test7: saa7134 breaks on gcc 2.95 |
| |
This compiler does not like dangling comma in funcs, so this patch is needed. For:
#define dprintk(fmt, arg...) if (core_debug) \ printk(KERN_DEBUG "%s/core: " fmt, dev->name, ## arg)
Lines like this:
dprintk("hwinit1\n");
should be hacked like this:
dprintk("hwinit1\n", "");
Or maybe someone knows a better solution.
-- Eyal Lebedinsky (eyal@eyal.emu.id.au) <http://samba.org/eyal/>--- linux/drivers/media/video/saa7134/saa7134-core.c.orig Wed Oct 15 10:30:44 2003 +++ linux/drivers/media/video/saa7134/saa7134-core.c Wed Oct 15 10:31:10 2003 @@ -624,7 +624,7 @@ /* early init (no i2c, no irq) */ static int saa7134_hwinit1(struct saa7134_dev *dev) { - dprintk("hwinit1\n"); + dprintk("hwinit1\n", ""); saa_writel(SAA7134_IRQ1, 0); saa_writel(SAA7134_IRQ2, 0); @@ -675,7 +675,7 @@ /* late init (with i2c + irq) */ static int saa7134_hwinit2(struct saa7134_dev *dev) { - dprintk("hwinit2\n"); + dprintk("hwinit2\n", ""); saa7134_video_init2(dev); saa7134_tvaudio_init2(dev); @@ -703,7 +703,7 @@ /* shutdown */ static int saa7134_hwfini(struct saa7134_dev *dev) { - dprintk("hwfini\n"); + dprintk("hwfini\n", ""); switch (dev->pci->device) { case PCI_DEVICE_ID_PHILIPS_SAA7134: | |