Messages in this thread | | | Date | Mon, 13 Oct 2003 03:24:31 -0700 | From | Andrew Morton <> | Subject | Re: ReiserFS patch for updating ctimes of renamed files |
| |
Hans Reiser <reiser@namesys.com> wrote: > > In theory it is cleaner and purer to do it the way we did. In practice, > Alex's problem seems like a real one, and I don't know how hard it is to > change tar to do the right thing. We'll discuss it in a small seminar > today.
It would be best to make this change. minix, ext2 and ext3 do set ctime, so it is "the Linux standard".
btw, this code:
old_dir->i_ctime = old_dir->i_mtime = CURRENT_TIME; new_dir->i_ctime = new_dir->i_mtime = CURRENT_TIME; old_inode->i_ctime = CURRENT_TIME;
should avoid evaluating CURRENT_TIME three times: is has some computational cost and if an interrupt happens at the wrong time you end up with differing times in the inode(s).
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |