lkml.org 
[lkml]   [2003]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: ReiserFS patch for updating ctimes of renamed files
Hans Reiser <reiser@namesys.com> wrote:
>
> In theory it is cleaner and purer to do it the way we did. In practice,
> Alex's problem seems like a real one, and I don't know how hard it is to
> change tar to do the right thing. We'll discuss it in a small seminar
> today.

It would be best to make this change. minix, ext2 and ext3 do set ctime,
so it is "the Linux standard".

btw, this code:

old_dir->i_ctime = old_dir->i_mtime = CURRENT_TIME;
new_dir->i_ctime = new_dir->i_mtime = CURRENT_TIME;
old_inode->i_ctime = CURRENT_TIME;

should avoid evaluating CURRENT_TIME three times: is has some computational
cost and if an interrupt happens at the wrong time you end up with
differing times in the inode(s).


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:49    [W:0.062 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site