lkml.org 
[lkml]   [2003]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subjectfailing unregister_ioctl32 is pretty fatal condition -- fix up message level
Hi!

AFAICS, kernel is likely to crash if someone does said ioctl after
failed unregister. Please apply,
Pavel

Index: linux/drivers/ieee1394/video1394.c
===================================================================
--- linux.orig/drivers/ieee1394/video1394.c 2003-10-09 00:40:50.000000000 +0200
+++ linux/drivers/ieee1394/video1394.c 2003-09-09 12:59:48.000000000 +0200
@@ -1424,7 +1424,7 @@
ret |= unregister_ioctl32_conversion(VIDEO1394_IOC32_TALK_WAIT_BUFFER);
ret |= unregister_ioctl32_conversion(VIDEO1394_IOC32_LISTEN_POLL_BUFFER);
if (ret)
- PRINT_G(KERN_INFO, "Error unregistering ioctl32 translations");
+ PRINT_G(KERN_CRIT, "Error unregistering ioctl32 translations");
#endif

hpsb_unregister_protocol(&video1394_driver);
--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:49    [W:0.027 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site