Messages in this thread Patch in this message | | | Date | Fri, 10 Oct 2003 12:03:53 +0200 | From | Pavel Machek <> | Subject | failing unregister_ioctl32 is pretty fatal condition -- fix up message level |
| |
Hi!
AFAICS, kernel is likely to crash if someone does said ioctl after failed unregister. Please apply, Pavel
Index: linux/drivers/ieee1394/video1394.c =================================================================== --- linux.orig/drivers/ieee1394/video1394.c 2003-10-09 00:40:50.000000000 +0200 +++ linux/drivers/ieee1394/video1394.c 2003-09-09 12:59:48.000000000 +0200 @@ -1424,7 +1424,7 @@ ret |= unregister_ioctl32_conversion(VIDEO1394_IOC32_TALK_WAIT_BUFFER); ret |= unregister_ioctl32_conversion(VIDEO1394_IOC32_LISTEN_POLL_BUFFER); if (ret) - PRINT_G(KERN_INFO, "Error unregistering ioctl32 translations"); + PRINT_G(KERN_CRIT, "Error unregistering ioctl32 translations"); #endif hpsb_unregister_protocol(&video1394_driver); -- When do you have a heart between your knees? [Johanka's followup: and *two* hearts?] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |