Messages in this thread | | | From | Ingo Oeser <> | Subject | Re: [PATCH] kfree_skb() bug in 2.4.22 | Date | Fri, 10 Oct 2003 17:43:48 +0200 |
| |
On Friday 10 October 2003 15:00, David S. Miller wrote: > Ingo Oeser <ioe-lkml@rameria.de> wrote: > > Would you mind __attribute_nonnull__ for these functions, if we > > enable GCC 3.3 support for this[1]? > > I would say yes, but why? All this attribute does is optimize > away tests for NULL which surprise surprise we don't have any > of in kfree_skb().
And it wouldn't warn about passing NULL to these functions? That's bad... But maybe sparse/smatch are better for this...
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |