lkml.org 
[lkml]   [2003]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] CONFIG_* In Comments Considered Harmful
    On Wed, Oct 01, 2003 at 02:26:19PM +0100, Matthew Wilcox wrote:
    >
    > I reviewed the dependency list for a file this morning to see why it was
    > being unnecessarily recompiled (a little fetish of mine, mostly harmless).
    > I was a little discombobulated to find this line:

    Mmm discombobulation.

    > $(wildcard include/config/higmem.h) \
    >
    > Naturally, I assumed a typo somewhere. It turns out there is indeed
    > a CONFIG_HIGMEM in include/linux/mm.h, but it's in a comment. The
    > fixdep script doesn't parse C itself, so it doesn't know that this should
    > be ignored.

    Maybe it should be taught to parse comments? There are zillions of
    #endif /* CONFIG_FOO */
    braces in the tree. Why is this one special ?

    Dave

    --
    Dave Jones http://www.codemonkey.org.uk
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:49    [W:0.044 / U:94.004 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site