[lkml]   [2003]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] CONFIG_* In Comments Considered Harmful
On Wed, Oct 01, 2003 at 02:26:19PM +0100, Matthew Wilcox wrote:
> I reviewed the dependency list for a file this morning to see why it was
> being unnecessarily recompiled (a little fetish of mine, mostly harmless).
> I was a little discombobulated to find this line:

Mmm discombobulation.

> $(wildcard include/config/higmem.h) \
> Naturally, I assumed a typo somewhere. It turns out there is indeed
> a CONFIG_HIGMEM in include/linux/mm.h, but it's in a comment. The
> fixdep script doesn't parse C itself, so it doesn't know that this should
> be ignored.

Maybe it should be taught to parse comments? There are zillions of
#endif /* CONFIG_FOO */
braces in the tree. Why is this one special ?


Dave Jones
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2005-03-22 13:49    [W:0.160 / U:4.420 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site