Messages in this thread | | | Date | Mon, 06 Jan 2003 03:44:23 -0800 | From | Andrew Morton <> | Subject | Re: [ACPI] acpi_os_queue_for_execution() |
| |
"Grover, Andrew" wrote: > > > From: Pavel Machek [mailto:pavel@ucw.cz] > > Acpi seems to create short-lived kernel threads, and I don't quite > > understand why. > > > > In thermal.c > > > > > > tz->timer.data = (unsigned long) tz; > > tz->timer.function = acpi_thermal_run; > > tz->timer.expires = jiffies + (HZ * > > sleep_time) / 1000; > > add_timer(&(tz->timer)); > > > > and acpi_thermal_run creates kernel therad that runs > > acpi_thermal_check. Why is not acpi_thermal_check called directly? I > > don't like idea of thread being created every time thermal zone needs > > to be polled... > > Are we allowed to block in a timer callback? One of the things > thermal_check does is call a control method, which in turn can be very > slow, sleep, etc., so I'd guess that's why the code tries to execute > things in its own thread. >
acpi_thermal_run is doing many sinful things. Blocking memory allocations as well as launching kernel threads from within a timer handler.
Converting it to use schedule_work() or schedule_delayed_work() would fix that up. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |