Messages in this thread | | | Date | Mon, 6 Jan 2003 12:15:31 -0700 | From | Tom Rini <> | Subject | Re: [PATCH] configurable LOG_BUF_SIZE |
| |
On Mon, Jan 06, 2003 at 11:05:49AM -0800, Randy.Dunlap wrote: > On Mon, 6 Jan 2003, Tom Rini wrote: > > | On Mon, Jan 06, 2003 at 10:57:01AM -0800, Randy.Dunlap wrote: > | > On Mon, 6 Jan 2003, Tom Rini wrote: > | > > | > | On Thu, Jan 02, 2003 at 03:09:17PM -0800, Randy.Dunlap wrote: > | > | > | > | > This patch to 2.5.54 make LOG_BUF_LEN a configurable option. > | > | > Actually its shift value is configurable, and that keeps it > | > | > a power of 2. > | > | > | > | Erm, why not just prompt for an int, slightly change the help wording, > | > | and then just give a default int value directly. > | > | > | > | Flexibility is good for everyone. > | > > | > Sure, I like that, but LOG_BUF_LEN must be a power of 2 (currently) > | > and I was trying not to rewrite that circular buffer code, that's all. > | > However, I will if that's desirable. > | > | I actually meant prompting for the shift value itself. > > I did think of that, but it's too user-unfriendly IMO. > Heck, it's even developer-unfriendly IMO.
I don't see how it's any worse than giving them a choice of 3-4 preset values. Especially with the current defaults being given as the if-in-doubt option :)
This is would also be a good reason to have a CONFIG_ADVANCED_OPTIONS globally, ala what's in arch/ppc/Kconfig now. If selected, you can pick some 'user-unfriendly' options, and otherwise a default is picked for you.
This is also a good argument for the TWEAKS stuff I talked about a while ago, but haven't found the time yet to finish the dependancy stuff (it works ala CONFIG stuff now, _except_ for a new TWEAK key).
-- Tom Rini (TR1265) http://gate.crashing.org/~trini/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |