lkml.org 
[lkml]   [2003]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] configurable LOG_BUF_SIZE
    On Mon, Jan 06, 2003 at 10:57:01AM -0800, Randy.Dunlap wrote:
    > On Mon, 6 Jan 2003, Tom Rini wrote:
    >
    > | On Thu, Jan 02, 2003 at 03:09:17PM -0800, Randy.Dunlap wrote:
    > |
    > | > This patch to 2.5.54 make LOG_BUF_LEN a configurable option.
    > | > Actually its shift value is configurable, and that keeps it
    > | > a power of 2.
    > |
    > | Erm, why not just prompt for an int, slightly change the help wording,
    > | and then just give a default int value directly.
    > |
    > | Flexibility is good for everyone.
    >
    > Sure, I like that, but LOG_BUF_LEN must be a power of 2 (currently)
    > and I was trying not to rewrite that circular buffer code, that's all.
    > However, I will if that's desirable.

    I actually meant prompting for the shift value itself.

    > And kconfig doesn't have a way to enforce the selected value...

    That is a shame, I've had to resort to doing checks like that at compile
    time for that reason.

    > Linus also told me that he's not crazy about this change.

    Maybe he would be, if it was cleaner than the current code in the end.
    :)

    --
    Tom Rini (TR1265)
    http://gate.crashing.org/~trini/
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:32    [W:0.020 / U:92.720 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site