lkml.org 
[lkml]   [2003]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [RFC] [PATCH] new modversions implementation
Date
In message <20030125215637.GA3571@mars.ravnborg.org> you write:
> On Sat, Jan 25, 2003 at 12:44:39PM -0600, Kai Germaschewski wrote:
>
> Just some small nit-picking..
>
> Sam
>
> diff -Nru a/kernel/module.c b/kernel/module.c
> --- a/kernel/module.c Sat Jan 25 12:25:07 2003
> +++ b/kernel/module.c Sat Jan 25 12:25:07 2003
>
> + kernel_gpl_symbols.num_syms = (__stop___ksymtab_gpl
> + - __start___ksymtab_gpl);
>
> The member "num_syms" says something about number of symbols,
> but is contains the syms_size. Misleading name.

I think you've missed the declaration:

extern const struct kernel_symbol __start___ksymtab[];
extern const struct kernel_symbol __stop___ksymtab[];
extern const struct kernel_symbol __start___ksymtab_gpl[];
extern const struct kernel_symbol __stop___ksymtab_gpl[];

Thanks for the feedback!
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:32    [from the cache]
©2003-2011 Jasper Spaans