Messages in this thread | | | Date | Fri, 24 Jan 2003 00:15:49 +0100 | From | romieu@fr ... | Subject | Re: [Patch] Fix errors in aironet4500 driver (cli_sti_removal-004) (fwd) |
| |
Michael Still <mikal@stillhq.com> : > > I'm resending this in the hope of people applying it. > > #endif /* AIRONET4500_H */ > diff -Nur linux-2.5.55/drivers/net/aironet4500_card.c linux-2.5.55-cli_sti_removal-002/drivers/net/aironet4500_card.c > --- linux-2.5.55/drivers/net/aironet4500_card.c Fri Jan 10 09:18:46 2003 > +++ linux-2.5.55-cli_sti_removal-002/drivers/net/aironet4500_card.c Thu Jan 9 22:24:11 2003 [...] > @@ -406,18 +398,18 @@ > > ((struct awc_private *)dev->priv)->bus = logdev; > > - cli(); > + spin_lock_irq(&aironet4500_lock); > if ( awc_init(dev) ){ > printk("card not found at irq %x io %lx\n",dev->irq, dev->base_addr); > if (card==0){ > - sti(); > + spin_unlock_irq(&aironet4500_lock); > return -1; > } > - sti(); > + spin_unlock_irq(&aironet4500_lock);
It isn't pretty and awc4500_pnp_probe() leaks memory with this return (hint: follow 'dev').
-- Ueimor - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |