lkml.org 
[lkml]   [2003]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH (take 2)][2.5] hangcheck-timer
> +#include <linux/smp_lock.h>

not needed anymore.

> +MODULE_AUTHOR("Joel Becker");
> +MODULE_LICENSE("GPL");

What about a MODULE_DESCRIPTION()?

> +static struct timer_list hangcheck_ticktock = {
> + function: hangcheck_fire,
> +};

Use C99 initializers instead.

> +} /* hangcheck_init() */

These comments are a bit against the usual kernel coding style,
espececially for that short function..

p.s. sorry for not noticing some of the stuff earlier
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:32    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site