Messages in this thread |  | | | Date | Wed, 15 Jan 2003 22:55:32 +0200 | | From | Yaacov Akiba Slama <> | | Subject | Re: [PATCH] Re: [BUG] cardbus/hotplugging still broken in 2.5.56 |
| |
jens.taprogge@rwth-aachen.de wrote:
>I am not sure if you have seen the patch I posted on l-k. It should fix >both issues. > I don't know enough about pci/cardbus, but in arch/i386/pci.c::pcibios_assign_resources, I can see the following :
if (!r->start && r->end) pci_assign_resource(dev, idx); without testing the result and without freeing the ressource for all index if it fails on one index. So I don't know if your tests are necessary. Beside that, testing (!r->start && r->end) seems to be more in sync with arch/i386/pci.c than testing r->flags
Thanks, Yaacov Akiba Slama
> >Jens > >On Wed, Jan 15, 2003 at 10:13:39PM +0200, Yaacov Akiba Slama wrote: > > >>Jens Taprogge wrote : >> >> >> >>>You are not freeing the possibly already allocated resources in case of >>>a failure of either pci_assign_resource() or pca_enable_device(). In >>>fact you are not even checking if pci_assign_resource() fails. That >>>seems wrong to me. >>> >>> >>There are two separate issues : >>1) Fix the "ressource collisions" problem (and irq not known). >>2) Freeing ressources in case of failure of some functions. >> >>My patch solves the first issue only in order to make cardbus with rom work. >>The point 2 is a janitor work. >> >>Thanks, >>Yaacov Akiba Slama >> >> > > >
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |