[lkml]   [2003]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: any chance of 2.6.0-test*?
    On Sun, 12 Jan 2003, Rob Wilkens wrote:
    > On Sun, 2003-01-12 at 16:15, Matti Aarnio wrote:

    > > At first, read Documentation/CodingStyle of the kernel.
    > > Then have a look into:
    > >
    > > fs/open.c file do_sys_truncate() function.

    > - if (S_ISDIR(inode->i_mode))
    > - goto dput_and_out;
    > + if (S_ISDIR(inode->i_mode)){
    > + path_release(&nd);
    > + return error;
    > + }

    [snip same change in a few more changes]

    OK, now imagine the dcache locking changing a little bit.
    You need to update this piece of (duplicated) code in half
    a dozen places in just this function and no doubt in dozens
    of other places all over fs/*.c.

    From a maintenance point of view, a goto to a single block
    of error handling code is easier to maintain.


    Bravely reimplemented by the knights who say "NIH".
    Current spamtrap: <a href=mailto:""></a>
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2005-03-22 13:32    [W:0.043 / U:9.720 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site