Messages in this thread | | | Date | Sun, 12 Jan 2003 08:24:09 +0100 | From | Adrian Bunk <> | Subject | Re: [PATCH] (revised) fix net/irda warnings for 2.4.21-pre3 |
| |
On Sun, Jan 12, 2003 at 03:42:25AM +0100, Tony wrote:
> Adrian, > > You're right, I seem to have missed quite a lot, I have double-checked > things and updated the patch-file on the website. >... > Tony > > P.S. This one doesn't give any warnings in a compile test.
Really???
2.95 still gives me several valid warnings like e.g.:
<-- snip -->
... gcc -D__KERNEL__ -I/home/bunk/linux/kernel-2.4/linux-2.4.20-ac/include -Wall -Ws trict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2 -march=k6 -nostdinc -iwithprefix include -DKBUILD_BASENAME=ircomm_tty_attach -c -o ircomm_tty_attach.o ircomm_tty_attach.c ircomm_tty_attach.c: In function `ircomm_tty_disconnect_indication': ircomm_tty_attach.c:360: warning: too few arguments for format ...
<-- snip -->
In this case the bug in your patch is pretty obvious:
- IRDA_DEBUG(2, __FUNCTION__ "()\n"); + IRDA_DEBUG(2, "%s()\n");
cu Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |