Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH] Make `obsolete params' work correctly if MODULE_SYMBOL_PREFIX is non-empty | Date | Fri, 10 Jan 2003 21:20:31 +1100 |
| |
In message <20030110015203.A16268@twiddle.net> you write: > On Wed, Jan 08, 2003 at 10:56:51PM +1100, Rusty Russell wrote: > > + char sym_name[strlen(obsparm[i].name) + 2]; > > Are you really intending to use variable sized allocation > on the kernel stack?
Yep. Maximum length of obsolete parameter name in current kernel: seq_default_timer_resolution (28 chars).
It's far more likely that someone will hit the unchecked kmalloc allocations in arch/alpha/kernel/modules.c 8)
Hope that helps, Rusty. -- Anyone who quotes me in their sig is an idiot. -- Rusty Russell. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |