lkml.org 
[lkml]   [2002]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] 2.4.20 Direct IO patch for NFS. (Note: a trivial API change...)
    On Mon, Sep 30, 2002 at 08:34:04PM +0200, Trond Myklebust wrote:
    > diff -u --recursive --new-file linux-2.4.20-pre8/fs/block_dev.c linux-2.4.20-directio/fs/block_dev.c
    > --- linux-2.4.20-pre8/fs/block_dev.c Sun May 12 02:26:03 2002
    > +++ linux-2.4.20-directio/fs/block_dev.c Mon Sep 30 18:24:45 2002
    > @@ -131,8 +131,9 @@
    > return 0;
    > }
    >
    > -static int blkdev_direct_IO(int rw, struct inode * inode, struct kiobuf * iobuf, unsigned long blocknr, int blocksize)
    > +static int blkdev_direct_IO(int rw, struct file * filp, struct kiobuf * iobuf, unsigned long blocknr, int blocksize)
    > {
    > + struct inode * inode = filp->f_dentry->d_inode->i_mapping->host;
    > return generic_direct_IO(rw, inode, iobuf, blocknr, blocksize, blkdev_get_block);
    > }
    >

    isn't that two dereferences more than necessary for a local filesystem?

    --
    Revolutions do not require corporate support.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:29    [W:0.020 / U:121.048 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site