Messages in this thread | | | Date | Sun, 29 Sep 2002 18:26:43 +0100 | From | Christoph Hellwig <> | Subject | Re: [PATCH] Use __attribute__((malloc)) for gcc 3.2 |
| |
On Sun, Sep 29, 2002 at 05:27:31PM +0200, Andi Kleen wrote: > -extern pgd_t *pgd_alloc(struct mm_struct *); > +extern pgd_t *pgd_alloc(struct mm_struct *) malloc_function;
Anz chance you could make that __malloc? That how the other atrributes in the kernel (e.g. __init/__exit) work.
> +/* Function allocates new memory and return cannot alias with anything */ > +#define malloc_function __attribute__((malloc)) > +/* Never inline */ > +#define noinline __attribute__((noinline)) > +#else > +#define malloc_function > +#define noinline > +#endif
Dito for __noinline? And IMHO compiler.h is the better place for this.
BTW, do you have any stats on the better optimization? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |