Messages in this thread | | | Date | Sun, 29 Sep 2002 19:56:12 -0400 | From | Pete Zaitcev <> | Subject | Re: sparc32 sunrpc.o |
| |
> Date: Sun, 29 Sep 2002 12:22:39 +0200 > From: Tomas Szepe <szepe@pinerecords.com>
> +++ linux-2.4.20-pre8/arch/sparc/kernel/sparc_ksyms.c 2002-09-29 11:45:33.000000000 +0200 > +#ifdef CONFIG_HIGHMEM > +#include <asm/highmem.h> > +#endif
OK, this is actually correct, I think. Looks funny. :)
> +++ linux-2.4.20-pre8/arch/sparc/mm/Makefile 2002-09-29 11:45:33.000000000 +0200 > @@ -11,7 +11,7 @@ > $(CC) $(AFLAGS) -ansi -c -o $*.o $< > > O_TARGET := mm.o > -obj-y := fault.o init.o loadmmu.o generic.o extable.o btfixup.o > +obj-y := fault.o init.o loadmmu.o generic.o extable.o highmem.o btfixup.o
Why is this not obj-$(CONFIG_HIGHMEM) ?
> +/* in mm/memory.c */ > +extern struct page *highmem_start_page; > +
I would not do this. I would try to include <linux/highmem.h> into arch/sparc/mm/highmem.c (instead of <asm/highmem.h> as you did).
Also, now that you moved a bunch of implementation out of inlines, try to trim the #include list at the top of <asm-sparc/highmem.h>. For instance, asm/vaddrs.h is a suspect.
The rest of the patch is sane, as far as I can tell. I do not have a ready to run 2.4 sparc box, sorry. Please ask sparclinux@vger people to test, especially Uzi.
-- Pete - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |