Messages in this thread | | | Date | Thu, 26 Sep 2002 12:35:36 +1000 | From | Greg Ungerer <> | Subject | Re: [PATCH]: 2.5.38uc1 (MMU-less support) |
| |
Hi Matthew,
Some more comments on the ethernet driver.
BTW, the original this came from is in the kernel tree at arch/ppc/8xx_io/fec.c.
Matthew Wilcox wrote: > Motorola 5272 ethernet driver: > * In Config.in, let's conditionalise it on CONFIG_PPC or something > * Can you use module_init() so it doesn't need an entry in Space.c?
I don't think this will work. This is not a device that can be determined to be present like a PCI device. It is more like an ISA device, it needs to be probed to figure out if it is really there. I can't see any way not to use Space.c for non-auto-detectable type devices... (Offcourse I could be missing something :-)
> * You're defining CONFIG_* variables in the .c file. I don't know whether > this is something we're still trying to avoid doing ... Greg, you seem > to be CodingStyle enforcer, what's the word?
I missed this the first time through :-) I am not sure what you mean, CodingStyle enforcer? Can you elaborate for me?
Regards Greg
------------------------------------------------------------------------ Greg Ungerer -- Chief Software Wizard EMAIL: gerg@snapgear.com SnapGear Pty Ltd PHONE: +61 7 3435 2888 825 Stanley St, FAX: +61 7 3891 3630 Woolloongabba, QLD, 4102, Australia WEB: www.SnapGear.com
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |