lkml.org 
[lkml]   [2002]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] Module rewrite 2/20: bigrefs
On Wednesday September 25, rusty@rustcorp.com.au wrote:
> +static inline void bigref_init(struct bigref *ref, int value)
> +{
> + unsigned int i;
> + atomic_set(&ref->ref[0].counter, value);
> + for (i = 1; i < NR_CPUS; i++)
-----------------^
> + atomic_set(&ref->ref[i].counter, 0);
> + ref->waiter = NULL; /* To trap bugs */
> +}

Should this be '0', or should there be a comment explaining why it
one?

NeilBrown
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:29    [W:0.028 / U:1.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site