lkml.org 
[lkml]   [2002]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: Linux 2.5.37
On Fri, 20 Sep 2002, Linus Torvalds wrote:

>...
> Patrick Mochel <mochel@osdl.org>:
>...
> o ACPI: move PREFIX to a common header
>...


This patch that moved PREFIX to acpi_bus.h broke the compilation of
drivers/acpi/numa.c because this file didn't include acpi_bus.h:

<-- snip -->

...
gcc -Wp,-MD,./.numa.o.d -D__KERNEL__
-I/home/bunk/linux/kernel-2.5/linux-2.5.37-full/include -Wall -Wstrict-prototypes -Wno-trigraphs -O2
-fomit-frame-pointer -fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2
-march=k6 -I/home/bunk/linux/kernel-2.5/linux-2.5.37-full/arch/i386/mach-generic
-nostdinc -iwithprefix include -D_LINUX -I/home/bunk/linux/kernel-2.5/linux-2.5.37-full/d
rivers/acpi/include -DACPI_DEBUG_OUTPUT -DKBUILD_BASENAME=numa -c -o
numa.o numa.c
numa.c: In function `acpi_table_print_srat_entry':
numa.c:48: parse error before `PREFIX'
...
make[2]: *** [numa.o] Error 1
make[2]: Leaving directory
`/home/bunk/linux/kernel-2.5/linux-2.5.37-full/drivers/acpi'

<-- snip -->


The fix is simple:


--- drivers/acpi/numa.c.old 2002-09-20 19:05:06.000000000 +0200
+++ drivers/acpi/numa.c 2002-09-20 19:06:48.000000000 +0200
@@ -29,6 +29,7 @@
#include <linux/types.h>
#include <linux/errno.h>
#include <linux/acpi.h>
+#include "acpi_bus.h"

extern int __init acpi_table_parse_madt_family (enum acpi_table_id id, unsigned long madt_size, int entry_id, acpi_madt_entry_handler handler);

cu
Adrian

--

You only think this is a free country. Like the US the UK spends a lot of
time explaining its a free country because its a police state.
Alan Cox

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:29    [W:0.029 / U:1.852 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site