Messages in this thread | | | Date | Wed, 18 Sep 2002 12:33:46 -0400 | From | Jeff Garzik <> | Subject | Re: [patch 3/3] 2.5.36 i2c new adapter i2c-pport driver |
| |
Albert Cranford wrote: > +static int bit_pport_init(void) > +{ > + if (!request_region((base+2),1, "i2c (PPORT adapter)")) { > + return -ENODEV; > + } else { > + > + /* test for PPORT adap. */ > + > + > + PortData=inb(base+2); > + PortData= (PortData SET_SDA) SET_SCL; > + outb(PortData,base+2); > + > + if (!(inb(base+2) | 0x06)) { /* SDA and SCL will be high */ > + DEBINIT(printk("i2c-pport.o: SDA and SCL was low.\n")); > + return -ENODEV; > + } else { > + > + /*SCL high and SDA low*/ > + PortData = PortData SET_SCL CLR_SDA; > + outb(PortData,base+2); > + udelay(400);
use schedule_timeout() instead of udelay() since you're in process context. otherwise, looks ok...
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |