lkml.org 
[lkml]   [2002]   [Sep]   [14]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateSat, 14 Sep 2002 14:41:18 +0100
FromMatthew Wilcox <>
SubjectRe: [PATCH] 2.5.34-bk fcntl lockup
On Sat, Sep 14, 2002 at 12:18:11PM +0200, Petr Vandrovec wrote:
> Hi Linus,
>    please apply this. 

agreed, please apply.

> Fixes endless loop without schedule which happens as soon as smbd 
> invokes fcntl64(7, F_SETLK64, ...). fcntl_setlk64 gets cmd F_SETLK64,
> not F_SETLK tested in the loop;

i guess the LTP testsuite isn't quite comprehensive enough yet, it should
have caught this.

> Maybe return value from posix_lock_file should be changed to -EINPROGRESS 
> or -EJUKEBOX instead of testing passed cmd in callers, but this oneliner 
> works too. If you preffer changing posix_lock_file return value to clearly 
> distinugish between -EAGAIN and lock request queued, I'll do that.

i'll look at that idea, hadn't occurred to me before.

-- 
Revolutions do not require corporate support.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:28    [from the cache]
©2003-2008