Messages in this thread | | | Date | Thu, 12 Sep 2002 13:52:22 +0200 | From | Jens Axboe <> | Subject | Re: Patch: linux-2.5.34/drivers/ide/ide.c was building list of drives in reverse order |
| |
On Thu, Sep 12 2002, Adam J. Richter wrote: > ata_attach in linux-2.5.34/drivers/ide/ide.c builds a list of > IDE drives that do not yet have a device driver bound to them, in case > ide-disk, ide-scsi, or whatever driver you want to use is not loaded > yet. > > The problem was that ata_attach was adding to the head of > the list, so the list was being built in reverse order. So, if > you had two IDE disks, and ide-disk was a loadable module, the > devfs entries for the disks would be numbered in reverse (the > first disk would be /dev/discs/disc1, and the second would be > /dev/discs/disc0). > > The follow patch fixes the problem by changing the relevant > list_add to list_add_tail. Incidentally, the generic code > in drivers/base/ already does it this way.
Patch looks right (its obviously the right thing to do), thanks
-- Jens Axboe
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |