lkml.org 
[lkml]   [2002]   [Sep]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH] Re: 2.5.33 PNPBIOS does not compile
    From
    Date
    On Sun, 2002-09-01 at 09:14, Nicholas Miell wrote:
    > pnpbios_core.c: In function `call_pnp_bios':
    > pnpbios_core.c:167: invalid lvalue in unary `&'
    > pnpbios_core.c:167: invalid lvalue in unary `&'
    > pnpbios_core.c:169: invalid lvalue in unary `&'
    > pnpbios_core.c:169: invalid lvalue in unary `&'
    > pnpbios_core.c: In function `pnpbios_init':
    > pnpbios_core.c:1276: invalid lvalue in unary `&'
    > pnpbios_core.c:1276: invalid lvalue in unary `&'
    > pnpbios_core.c:1277: invalid lvalue in unary `&'
    > pnpbios_core.c:1277: invalid lvalue in unary `&'
    > pnpbios_core.c:1278: invalid lvalue in unary `&'
    > pnpbios_core.c:1278: invalid lvalue in unary `&'
    > make[2]: *** [pnpbios_core.o] Error 1
    > make[2]: Target `first_rule' not remade because of errors.
    > make[1]: *** [pnp] Error 2
    >
    > ... which is the result of the expansion of the Q_SET_SEL and Q2_SET_SEL
    > macros.
    Yes, this should fix the problem.

    diff --exclude-from=/home/ldb/src/linux-exclude -urNdp linux-2.5.32/drivers/pnp/pnpbios_core.c linux-2.5.32_pnpbelow/drivers/pnp/pnpbios_core.c
    --- linux-2.5.32/drivers/pnp/pnpbios_core.c 2002-08-27 21:26:32.000000000 +0200
    +++ linux-2.5.32_pnpbelow/drivers/pnp/pnpbios_core.c 2002-08-31 18:38:38.000000000 +0200
    @@ -127,11 +127,11 @@ __asm__(

    #define Q_SET_SEL(cpu, selname, address, size) \
    set_base(cpu_gdt_table[cpu][(selname) >> 3], __va((u32)(address))); \
    -set_limit(&cpu_gdt_table[cpu][(selname) >> 3], size)
    +set_limit(cpu_gdt_table[cpu][(selname) >> 3], size)

    #define Q2_SET_SEL(cpu, selname, address, size) \
    set_base(cpu_gdt_table[cpu][(selname) >> 3], (u32)(address)); \
    -set_limit(&cpu_gdt_table[cpu][(selname) >> 3], size)
    +set_limit(cpu_gdt_table[cpu][(selname) >> 3], size)

    /*
    * At some point we want to use this stack frame pointer to unwind
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2005-03-22 13:22    [W:0.024 / U:89.940 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site