lkml.org 
[lkml]   [2002]   [Aug]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: PCI<->PCI bridges, transparent resource fix
Date
>-	} else {
>- /*
>- * Ugh. We don't know enough about this bridge. Just assume
>- * that it's entirely transparent.
>- */
>- printk(KERN_ERR "Unknown bridge resource %d: assuming transparent\n", 0);
>- child->resource[0] = child->parent->resource[0];
> }

BTW, in the case of really closed resources, you just removed the "else"
case. I don't have the kernel sources at hand at the moment (still
on vacation ;) So I can't check how pci_dev is initialized on alloc,
but shouldn't we make sure the resoure pointer of the child is either
NULL or points to some properly zeroed out resource structure ?

I know the "closed resources" patch we used to have in some PPC kernel
trees did that explicitely in the "else" case here.

Ben.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:27    [W:1.702 / U:0.328 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site