[lkml]   [2002]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH] fix HIPQUAD macro in kernel.h
Hi Dave!

Below is a fix for the HIPQUAD macro in kernel.h. The macro is currently
not endian-aware - it just assumes running on a little-endian machine.

If you don't like the #ifdefs in kernel.h, the macros could be moved into

Please apply, thanks

--- linux-2.4.19-rc5-plain/include/linux/kernel.h Wed Aug 7 22:55:03 2002
+++ linux-2.4.19-rc5-endian/include/linux/kernel.h Thu Aug 8 11:34:13 2002
@@ -12,6 +12,7 @@
#include <linux/stddef.h>
#include <linux/types.h>
#include <linux/compiler.h>
+#include <asm/byteorder.h>

/* Optimization barrier */
/* The "volatile" is due to gcc bugs */
@@ -128,11 +129,17 @@
((unsigned char *)&addr)[2], \
((unsigned char *)&addr)[3]

+#if defined(__LITTLE_ENDIAN)
#define HIPQUAD(addr) \
((unsigned char *)&addr)[3], \
((unsigned char *)&addr)[2], \
((unsigned char *)&addr)[1], \
((unsigned char *)&addr)[0]
+#elif defined(__BIG_ENDIAN)
+#error "Please fix asm/byteorder.h"
+#endif /* __LITTLE_ENDIAN */

* min()/max() macros that also do
Live long and prosper
- Harald Welte /
GCS/E/IT d- s-: a-- C+++ UL++++$ P+++ L++++$ E--- W- N++ o? K- w--- O- M+
V-- PS++ PE-- Y++ PGP++ t+ 5-- !X !R tv-- b+++ !DI !D G+ e* h--- r++ y+(*)[unhandled content-type:application/pgp-signature]
 \ /
  Last update: 2005-03-22 13:27    [W:0.083 / U:8.960 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site