Messages in this thread | | | Date | Wed, 7 Aug 2002 10:29:49 +0530 | From | "Vamsi Krishna S ." <> | Subject | Re: [PATCH] kprobes for 2.5.30 |
| |
Hi Rusty,
On Wed, Aug 07, 2002 at 10:55:04AM +1000, Rusty Russell wrote: > In message <20020806164242.B22164@in.ibm.com> you write: > > - move trap1 and trap3 interrupt gates only under CONFIG_KPROBES. Please > > note that if we don't do this, we need to call restore_interrupts() > > from the dummy (post_)kprobe_handler() in include/asm-i386/kprobes.h > > when CONFIG_KPROBES is off. I didn't like this subtle side effect. hence > > the #ifdef CONFIG_KPROBES around _set_trap_gate. Still, the calling > > conventions of do_debug and do_int3 remain independent of CONFIG_KPROBES. > > Hmm, I thought about this but then decided against it. Your way is > pretty subtle too: I think I prefer the restore_interrupts() > explicitly after the (failed) call to kprobe_handler, ie (on top of > your patch, which looks excellent):
I agree this one is even better.
Thanks, Vamsi.
> <snip patch>
-- Vamsi Krishna S. Linux Technology Center, IBM Software Lab, Bangalore. Ph: +91 80 5044959 Internet: vamsi@in.ibm.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |