Messages in this thread | | | Date | Wed, 7 Aug 2002 23:02:25 +0200 | From | Kurt Garloff <> | Subject | Re: [PATCH] conditionally re-enable per-disk stats, convert to seq_file |
| |
Hi Christoph,
On Tue, Aug 06, 2002 at 04:08:48PM +0200, Christoph Hellwig wrote: > This patch against 2.4.20-pre1 converts /proc/partitions to the seq_file > interface as in 2.5, makes it report the sard-style extended disk > statistics condititional on CONFIG_BLK_STATS and disables the gathering > of those totally otherwise to not waste memory and processing power. > > This patch is based on the concept of Kurt's statistics patch, although > it is implemented very differently to avoid #ifdef hell.
Actually, I was expecting criticism due to the ifdef stuff I did and was prepared to come up with something better. But I also learned never to put effort into something before being asked to ...
Your patch looks fine to me. Thanks for preparing it!
Regards, -- Kurt Garloff <kurt@garloff.de> [Eindhoven, NL] Physics: Plasma simulations <K.Garloff@TUE.NL> [TU Eindhoven, NL] Linux: SCSI, Security <garloff@suse.de> [SuSE Nuernberg, DE] (See mail header or public key servers for PGP2 and GPG public keys.) [unhandled content-type:application/pgp-signature] | |