lkml.org 
[lkml]   [2002]   [Aug]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subjectweird padding in linux/timex.h, struct timex
Hi, 

struct timex in include/linux/timex.h is defined as

struct timex
{
...
int :32; int :32; int :32; int :32;
int :32; int :32; int :32; int :32;
int :32; int :32; int :32; int :32;
};

I assume that this is used as padding. Is there any reason for using
bitfields as padding? If there is, a comment to that effect would be
nice. If there isn't, the following patch makes the padding explicit.

--- 2.4.19-vanilla/include/linux/timex.h Sun Aug 4 19:16:59 2002
+++ 2.4.19-mx/include/linux/timex.h Tue Aug 6 13:49:32 2002
@@ -182,9 +182,7 @@
long errcnt; /* calibration errors (ro) */
long stbcnt; /* stability limit exceeded (ro) */

- int :32; int :32; int :32; int :32;
- int :32; int :32; int :32; int :32;
- int :32; int :32; int :32; int :32;
+ char __pad[12 * 4]; /* padding */
};

/*

--
I am PINK, hear me ROAR

http://vipe.technion.ac.il/~mulix/
http://syscalltrack.sf.net/
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2005-03-22 13:27    [W:0.038 / U:0.328 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site