Messages in this thread Patch in this message | | | Date | Tue, 6 Aug 2002 14:15:49 +0300 | From | Muli Ben-Yehuda <> | Subject | weird padding in linux/timex.h, struct timex |
| |
Hi,
struct timex in include/linux/timex.h is defined as
struct timex { ... int :32; int :32; int :32; int :32; int :32; int :32; int :32; int :32; int :32; int :32; int :32; int :32; };
I assume that this is used as padding. Is there any reason for using bitfields as padding? If there is, a comment to that effect would be nice. If there isn't, the following patch makes the padding explicit.
--- 2.4.19-vanilla/include/linux/timex.h Sun Aug 4 19:16:59 2002 +++ 2.4.19-mx/include/linux/timex.h Tue Aug 6 13:49:32 2002 @@ -182,9 +182,7 @@ long errcnt; /* calibration errors (ro) */ long stbcnt; /* stability limit exceeded (ro) */ - int :32; int :32; int :32; int :32; - int :32; int :32; int :32; int :32; - int :32; int :32; int :32; int :32; + char __pad[12 * 4]; /* padding */ }; /*
-- I am PINK, hear me ROAR
http://vipe.technion.ac.il/~mulix/ http://syscalltrack.sf.net/ [unhandled content-type:application/pgp-signature] | |