lkml.org 
[lkml]   [2002]   [Aug]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] 2.4.19 warnings cleanup
    From
    Date
    Alan Cox <alan@lxorguk.ukuu.org.uk> writes:

    > > --- linux/drivers/net/ppp_generic.c.orig Sat Aug 3 17:13:58 2002
    > > +++ linux/drivers/net/ppp_generic.c Sat Aug 3 19:11:54 2002
    > > @@ -378,7 +378,7 @@
    > > {
    > > struct ppp_file *pf = file->private_data;
    > > DECLARE_WAITQUEUE(wait, current);
    > > - ssize_t ret;
    > > + ssize_t ret = 0; /* suppress compiler warning */
    > > struct sk_buff *skb = 0;
    > >
    > > if (pf == 0)
    >
    >
    > Please don't do this. I'm regularly having to fix drivers where people
    > hid bugs this way rather than working out if it was a real problem. If
    > it is genuinely a compiler corner case then let the gcc folks know and
    > comment it but leave the warning.

    Ok.
    --
    Krzysztof Halasa
    Network Administrator
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:27    [W:0.023 / U:29.996 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site