Messages in this thread |  | | | From | Paul Mackerras <> | | Date | Mon, 5 Aug 2002 10:05:41 +1000 (EST) | | Subject | Re: [PATCH] 2.4.19 warnings cleanup |
| |
Alan Cox writes:
> > --- linux/drivers/net/ppp_generic.c.orig Sat Aug 3 17:13:58 2002 > > +++ linux/drivers/net/ppp_generic.c Sat Aug 3 19:11:54 2002 > > @@ -378,7 +378,7 @@ > > { > > struct ppp_file *pf = file->private_data; > > DECLARE_WAITQUEUE(wait, current); > > - ssize_t ret; > > + ssize_t ret = 0; /* suppress compiler warning */ > > struct sk_buff *skb = 0; > > > > if (pf == 0) > > > Please don't do this. I'm regularly having to fix drivers where people > hid bugs this way rather than working out if it was a real problem. If > it is genuinely a compiler corner case then let the gcc folks know and > comment it but leave the warning.
The code is in ppp_read actually OK; if you trace through the logic you can prove that ret is never actually used without being set first.
Paul. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |