Messages in this thread Patch in this message | | | From | Rusty Russell <> | Subject | Re: [PATCH] 2.5.32-smph | Date | Sat, 31 Aug 2002 15:21:24 +1000 |
| |
In message <E17ktU3-00035O-00@flint.arm.linux.org.uk> you write: > This patch appears not to be in 2.5.32, but applies cleanly. > > Use of cpu_online on UP causes the following warnings: > > page_alloc.c:555: warning: statement with no effect > proc_misc.c:297: warning: statement with no effect > proc_misc.c:313: warning: statement with no effect > dev.c:1824: warning: statement with no effect > > This patch fixes these warnings.
I prefer this fix, which also adds cpu_possible(i) for UP.
Name: cpu_possible for UP Author: Rusty Russell Status: Trivial
D: This patch defines cpu_possible() for non-SMP.
diff -urpN --exclude TAGS -X /home/rusty/devel/kernel/kernel-patches/current-dontdiff --minimal linux-2.5.32/include/linux/smp.h working-2.5.32-cpu-possible/include/linux/smp.h --- linux-2.5.32/include/linux/smp.h 2002-08-28 09:29:53.000000000 +1000 +++ working-2.5.32-cpu-possible/include/linux/smp.h 2002-08-29 15:30:49.000000000 +1000 @@ -94,9 +94,10 @@ int cpu_up(unsigned int cpu); static inline void smp_send_reschedule(int cpu) { } static inline void smp_send_reschedule_all(void) { } #define cpu_online_map 1 -#define cpu_online(cpu) ({ cpu; 1; }) +#define cpu_online(cpu) ({ BUG_ON((cpu) != 0); 1; }) #define num_online_cpus() 1 #define num_booting_cpus() 1 +#define cpu_possible(i) ({ BUG_ON((cpu) != 0); 1; }) struct notifier_block; -- Anyone who quotes me in their sig is an idiot. -- Rusty Russell. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |