lkml.org 
[lkml]   [2002]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch] scheduler fixes, 2.5.32-BK

    the attached patch adds two scheduler related fixes:

    - changes the migration code to use struct completion. Andrew pointed out
    that there might be a small window in where the up() touches the
    semaphore while the waiting task goes on and frees its stack. And
    completion is more suited for this kind of stuff anyway.

    - removes two unneeded exports, pointed out by Andrew.

    Ingo

    --- linux/kernel/sched.c.orig Fri Aug 30 09:34:34 2002
    +++ linux/kernel/sched.c Fri Aug 30 09:35:49 2002
    @@ -1901,7 +1901,7 @@
    typedef struct {
    list_t list;
    task_t *task;
    - struct semaphore sem;
    + struct completion done;
    } migration_req_t;

    /*
    @@ -1945,13 +1945,13 @@
    task_rq_unlock(rq, &flags);
    goto out;
    }
    - init_MUTEX_LOCKED(&req.sem);
    + init_completion(&req.done);
    req.task = p;
    list_add(&req.list, &rq->migration_queue);
    task_rq_unlock(rq, &flags);
    wake_up_process(rq->migration_thread);

    - down(&req.sem);
    + wait_for_completion(&req.done);
    out:
    preempt_enable();
    }
    @@ -2032,7 +2032,7 @@
    double_rq_unlock(rq_src, rq_dest);
    local_irq_restore(flags);

    - up(&req->sem);
    + complete(&req->done);
    }
    }

    --- linux/kernel/ksyms.c.orig Fri Aug 30 09:37:36 2002
    +++ linux/kernel/ksyms.c Fri Aug 30 09:37:38 2002
    @@ -496,8 +496,6 @@
    #endif

    EXPORT_SYMBOL(kstat);
    -EXPORT_SYMBOL(nr_running);
    -EXPORT_SYMBOL(nr_context_switches);

    /* misc */
    EXPORT_SYMBOL(panic);

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:28    [W:0.025 / U:0.352 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site