lkml.org 
[lkml]   [2002]   [Aug]   [30]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] 6/41 sound/oss/pss.c - convert cli to spinlocks
FromAlan Cox <>
Date30 Aug 2002 11:56:58 +0100
On Fri, 2002-08-30 at 08:47, Tomas Szepe wrote:
> > static pss_confdata *devc = &pss_data;
>                            ^ ^
> > +static spinlock_t lock=SPIN_LOCK_UNLOCKED;
> 
> > 				if (!pss_put_dspword(devc, *data++)) {
>                                                           ^
> > +					spin_unlock_irqrestore(&lock,flags);
> 
> 
> Would you please take care not to clutter the original sources with
> lines in a different C formatting style?

When you've ported that much code to a new locking mechanism then you
can moan. If he wants to take on the old OSS code and making it work in
the 2.5 universe as far as I (as the ex OSS code maintainer) am concened
he can format it how he likes

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:28    [from the cache]
©2003-2008