Messages in this thread | | | Date | Fri, 30 Aug 2002 00:26:42 +0200 | From | Pavel Machek <> | Subject | Re: input u-cleanup |
| |
Hi!
> > proc is clever enough not to need ifdefs, so this is probably good > > idea... > > > > Pavel > > If you could remove all the procfs #ifdefs from input.c, that'd be great. > But removing only those around unregistration IMHO doesn't make > > sense.
They can be safely dropped. I had patch to do that but droped it during merge. If you'll accept complete patch, I'll create it. [Or you can do it yourself, just killing #ifdef CONFIG_PROC_FS should do the trick].
> > > > --- clean/drivers/input/input.c Wed Aug 28 22:38:46 2002 > > +++ linux-swsusp/drivers/input/input.c Wed Aug 28 23:28:23 2002 > > @@ -800,11 +803,9 @@ > > > > static void __exit input_exit(void) > > { > > -#ifdef CONFIG_PROC_FS > > remove_proc_entry("devices", proc_bus_input_dir); > > remove_proc_entry("handlers", proc_bus_input_dir); > > remove_proc_entry("input", proc_bus); > > -#endif > > devfs_unregister(input_devfs_handle); > > if (unregister_chrdev(INPUT_MAJOR, "input")) > > printk(KERN_ERR "input: can't unregister char major %d", INPUT_MAJOR); > > > > -- > > Worst form of spam? Adding advertisment signatures ala sourceforge.net. > > What goes next? Inserting advertisment *into* email? >
-- Casualities in World Trade Center: ~3k dead inside the building, cryptography in U.S.A. and free speech in Czech Republic. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |