lkml.org 
[lkml]   [2002]   [Aug]   [28]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: Bug in kernel code?
FromLuca Barbieri <>
Date28 Aug 2002 06:29:59 +0200
On Wed, 2002-08-28 at 06:07, David S. Miller wrote:
>    From: Luca Barbieri <ldb@ldb.ods.org>
>    Date: 28 Aug 2002 06:10:39 +0200
> 
>    I'm not saying that it's serious bug, just that using __ffs is more
>    appropriate than reimplementing it incorrectly and inefficiently.
> 
> ffs won't find the smallest power of 2 >= some_arbitrary_value.
> That is what this code is doing.
Yes you are right, fls should be used there, not ffs.

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2005-03-22 12:28    [from the cache]
©2003-2008