Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [TRIVIAL] strlen("literal string") -> (sizeof("literal string")-1) | Date | Thu, 29 Aug 2002 13:09:05 +1000 |
| |
In message <200208282131.g7SLVVGx024191@siamese.dyndns.org> you write: > Here is a patch that does the same as what Keith Owens did in > his patch recently. > > Message-ID: <fa.iks3ohv.1flge08@ifi.uio.no> > From: Keith Owens <kaos@ocs.com.au> > Subject: [patch] 2.4.19 Generate better code for nfs_sillyrename > Date: Wed, 28 Aug 2002 07:08:17 GMT > > Using strlen() generates an unnecessary inline function expansion plus > dynamic stack adjustment. For constant strings, strlen() == sizeof()-1 > and the object code is better.
Disagree. If you really care make strlen use __builtin_constant_p(). Then authors don't have to sacrifice readability.
#define strlen(x) (__builtin_constant_p(x) ? sizeof(x)-1 : __strlen(x))
Rusty. -- Anyone who quotes me in their sig is an idiot. -- Rusty Russell. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |