lkml.org 
[lkml]   [2002]   [Aug]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] ad1848 infinite loop fix
    On Sun, 25 Aug 2002, Zwane Mwaikambo wrote:

    >
    > > --- linux-2.4.19/drivers/sound/ad1848.c.orig Sat Aug 24 23:19:54 2002
    > > +++ linux-2.4.19/drivers/sound/ad1848.c Sat Aug 24 23:20:58 2002
    > > @@ -3058,7 +3058,7 @@
    > > else
    > > printk(KERN_INFO "ad1848: Failed to initialize %s\n",
    > > devname);
    > >
    > > - return 0;
    > > + return -ENODEV;
    > > }
    > >
    > > static int __init ad1848_isapnp_probe(struct address_info *hw_config)
    >
    > This will break the isapnp probe in ad1848, the problem could possibly be
    > elsewhere. You have to be a bit careful when changing the return values of
    > functions in some of the older OSS code.
    >
    I just looked into some of the other drivers and they also use "return 0"
    in case of failure. So you are right, this is not the proper
    way to fix this! But this means that there are some generic problems
    with the loading of kernel modules!?

    If I use "return -ENODEV" the module will do the init stuff, fail, and
    thats it. With the original "return 0" the module will do the init
    stuff in an infinite loop. I do not think this is a problem inside
    the module since it looks like the main init function gets
    called over and over again (blocking the kernel and hence freezing
    the system).

    Gerald

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:28    [W:0.023 / U:1.244 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site