Messages in this thread | | | Date | Sat, 17 Aug 2002 15:17:04 -0400 | From | Benjamin LaHaise <> | Subject | Re: [patch] reduce stack usage of sanitize_e820_map |
| |
On Sat, Aug 17, 2002 at 11:18:11AM -0600, Eric W. Biederman wrote: > Benjamin LaHaise <bcrl@redhat.com> writes: > > > Hello, > > > > Currently, sanitize_e820_map uses 0x738 bytes of stack. The patch below > > moves the arrays into __initdata, reducing stack usage to 0x34 bytes. > > Can we keep the arrays in sanitize_e820_map and just mark then static > and __initdata? That would appear to be a cleaner solution. > Polluting the global kernel name space with these is not nice.
Nope. static conflicts with __initdata. If namespace pollution is a concern, just prefix them with e820_.
-ben -- "You will be reincarnated as a toad; and you will be much happier." - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |