Messages in this thread | | | Date | Tue, 13 Aug 2002 12:41:03 -0700 (PDT) | From | Linus Torvalds <> | Subject | Re: [patch] CLONE_SETTLS, CLONE_SETTID, 2.5.31-BK |
| |
On Tue, 13 Aug 2002, Ingo Molnar wrote: > > > > Except you actually test the CLONE_SETTLS bit.. > > We've tested clone_startup() with real threads on a 2.4-backported version > of yesterday's final TLS API quite extensively, and it works as expected. > (as we've tested earlier incarnations of the TLS API and code as well.)
It's still buggy, and you didn't read what I wrote.
+ /* + * Notify the child of the TID? + */ + if (clone_flags & CLONE_SETTLS) + if (put_user(p->pid, (pid_t *)childregs->edx)) + return -EFAULT;
Find the bug. Find the sentence I wrote that pointed it out last time. Notice how your testing did not find it, since you always just set both flags.
Linus
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |