lkml.org 
[lkml]   [2002]   [Aug]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [patch 6/12] hold atomic kmaps across generic_file_read
    Date
    On Monday 12 August 2002 09:45, Rusty Russell wrote:
    > On Fri, 9 Aug 2002 18:33:09 -0700 (PDT)
    > Linus Torvalds <torvalds@transmeta.com> wrote:
    > > repeat:
    > > kmap_atomic(..); // this increments preempt count
    > > nr = copy_from_user(..);
    >
    > Please please please use a different name for "I know I'm not preemptible but
    > I can handle it" or a flag or something.
    >
    > That leaves us with the possibility of a BUG() in the "normal" copy_to/from_user
    > for all those "I'm holding a spinlock while copying to userspace wheeee!" bugs.
    > Very common mistake for new kernel authors.

    That's the whole point of this: it's not a bug anymore. (It's a feature.)

    But agreed, a different name than preempt count would be nice, because it's
    evolving away from its original function. Is this a 'monitor'? (I don't
    think so.) Perhaps 'atomic_count' is more accurate.

    --
    Daniel
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:27    [W:0.020 / U:97.624 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site