Messages in this thread | | | Date | Sat, 06 Jul 2002 13:00:42 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH][RFT](2) minimal rmap for 2.5 - akpm tested |
| |
Linus Torvalds wrote: > > On Fri, 5 Jul 2002, Andrew Morton wrote: > > > > The box died, but not due to rmap. We have a lock ranking > > bug: > > > > do_exit > > ->mmput > > ->exit_mmap page_table_lock > > ->removed_shared_vm_struct > > ->lock_vma_mappings i_shared_lock > > I _think_ we should just move the remove_shared_vm_struct() down into the > case where we're closing the mapping, ie something like the appended. > > That way we _only_ do the actual page table stuff under the page table > lock, and do all the generic VM/FS stuff outside the lock. > > Comments?
That is basically what do_munmap() does. But I'm quite unfamiliar with the locking in there.
- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |