lkml.org 
[lkml]   [2002]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [patch] Fix suspend of the kseriod thread
    Date

    vojtech@suse.cz said:
    > Ok. Is the use in drivers/input/serio.c buggy?

    If it matters that the thread can miss wakeup events and sleep indefinitely
    while there's a 'SERIO_RESCAN' event pending, then yes it looks buggy.

    serio_thread() serio_rescan()
    -------------- --------------

    serio_handle_events();
    serio->event |= SERIO_RESCAN;
    wake_up(&serio_wait);
    sleep_on(&serio_wait);

    ...sleeps...

    If both serio_thread() and serio_rescan() hold the BKL you're OK. It looks
    like serio_rescan() doesn't, though.

    > What should be it replaced with?

    In general, the response 'anything but sleep_on' is considered appropriate.
    Try wait_event().

    --
    dwmw2


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:27    [W:0.021 / U:158.736 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site