Messages in this thread | | | Date | Fri, 26 Jul 2002 11:17:52 +0100 | From | Christoph Hellwig <> | Subject | Re: LVM 1.0.5 patch for Linux 2.4.19-rc3 |
| |
On Fri, Jul 26, 2002 at 02:47:56AM +0200, Marcin Dalecki wrote: > Or of course the normal u8 u16 and u32 and infally u64, which are so > much more explicit about the fact that we are actually dealig with > bit slices.
*nod*
> > All in all this patch would be _soooo_ much easier to review if you wouldn't > > mix random indentation changes with real fixes. > > Christoph applying the patch and rediffing with diffs "ingore white > space' options can help you here.
It's not that easy - he randomly moves the conditional statements on the if or else lines and changes brace placement..
> And plese note that this kind of problems wouldn't be that common > if we finally decided to make indent -kr -i8 mandatory.
nightly run on the bk repo... Larry, is that possible? :)
<advertise> for all those who want an indent with sane defaults:
version 0.2 of the 'portable' version of NetBSD is now available. get it from https://developer.berlios.de/project/filelist.php?group_id=192 and package it for $DISTRO.
feedback welcome. </advertise> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |