Messages in this thread | | | Subject | Re: [PATCH] IDE 104 | From | Alan Cox <> | Date | 26 Jul 2002 11:13:31 +0100 |
| |
On Fri, 2002-07-26 at 08:23, Marcin Dalecki wrote: > - Make the bit-sliced data types in hdreg.h use the bit-slice data types > instead of the generic ones. This makes clear that those are supposed > to be register masks.
Because its an external API it needs to remain constant. Swapping uchar/uint looks fine and the structure is off the drive anyway. However they should be __u16 __u8 __u32 so that C libraries and apps can still use the header (its __u16 because 'u16' cannot be exposed to user space directly or via libc)
Alan
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |