[lkml]   [2002]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] drivers/ide/qd65xx: no cli/sti (2.4.19-pre3 & 2.5.28)
    Vojtech Pavlik wrote:
    > On Thu, Jul 25, 2002 at 01:45:00AM +0200, Samuel Thibault wrote:
    >>Here are patches for 2.4.19-pre3 & 2.5.28 which free them from using
    >>cli/sti in qd65xx stuff.
    > Cool.
    >>(also using ide's OUT_BYTE / IN_BYTE btw)
    > In my opinion this doesn't make sense. The qd65xx is a VESA Local Bus
    > only hardware and is very very unlikely to be used on anything else than
    > an x86, where these defines are needed. Also, the ports written to are
    > not a part of the IDE controller region, so the IN_BYTE/OUT_BYTE macros
    > might not work there if it was ever used on a non-x86 machine. Also, it
    > makes the code less readable.

    Amen. BTW> I think proper fix is to simple *remove* the cli() cti()
    commands. They don't make much sense in first place.

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2005-03-22 13:27    [W:0.022 / U:62.032 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site